Fixes binaryninja-api#6825 #6916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue binaryninja-api#6825 by refining the handling of zero offsets in structure member evaluation. Key changes include:
- Replacing the dereference flag with a member resolution flag (memberResolved)
- Updating token rendering logic to always use instr.size for type casts
- Revising pointer arithmetic handling to only append arithmetic tokens when the offset is non-zero
Comments suppressed due to low confidence (3)
lang/c/pseudoc.cpp:2467
- [nitpick] Consider renaming 'memberResolved' to 'isMemberResolved' for improved clarity and consistency with boolean naming conventions.
bool memberResolved = false;
lang/c/pseudoc.cpp:2520
- Ensure that always using 'instr.size' instead of conditionally selecting a size value is the intended design for the type cast, as this change may affect the formatting of the resulting expression.
AppendSizeToken(instr.size, true, tokens);
lang/c/pseudoc.cpp:2536
- Confirm that the decision to only append pointer arithmetic tokens when offset is non-zero fully addresses the zero offset issue without unintended side effects in pointer arithmetic scenarios.
if (offset != 0)
bdash
force-pushed
the
test_fix_6825
branch
3 times, most recently
from
18f70cd to
7a4e006
Compare
rssor
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we weren't handling zero offsets from structures at all it looks like.
#6825